pgsql: Fix pg_dumpall so that when --clean is specified, it drops roles

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix pg_dumpall so that when --clean is specified, it drops roles
Date: 2009-04-11 20:23:05
Message-ID: 20090411202305.D64237540FB@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix pg_dumpall so that when --clean is specified, it drops roles and
tablespaces in an order that has some chance of working.
Per a complaint from Kevin Bailey.

This is a pre-existing bug, but given the lack of prior complaints I'm
not sure it's worth back-patching. In most cases failure of the DROP
commands wouldn't be that important anyway.

In passing, fix syntax errors in dumpCreateDB()'s queries for old servers;
these were apparently introduced in recent binary_upgrade patch.

Modified Files:
--------------
pgsql/src/bin/pg_dump:
pg_dumpall.c (r1.123 -> r1.124)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dumpall.c?r1=1.123&r2=1.124)

Browse pgsql-committers by date

  From Date Subject
Next Message User Gsmet 2009-04-12 12:55:40 pgfouine - pgfouine: implemented a simple garbage collector mechanism
Previous Message Alvaro Herrera 2009-04-11 18:38:54 pgsql: Make string more alike other similar messages.