| From: | Bruce Momjian <bruce(at)momjian(dot)us> | 
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> | 
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, jd(at)commandprompt(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> | 
| Subject: | Re: Unsupported effective_io_concurrency platforms | 
| Date: | 2009-04-02 19:56:02 | 
| Message-ID: | 200904021956.n32Ju2326923@momjian.us | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
Bruce Momjian wrote:
> Tom Lane wrote:
> > Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > > Joshua D. Drake wrote:
> > > Do we want to give a more informative error message, like "not supported
> > > on this platform?"
> > 
> > > The trick will be to fit this into the GUC framework.
> > 
> > You could do it by enforcing the limit in an assign hook, but I'm
> > not convinced it's worth the trouble.
> 
> I have created a patch to at least display a more helpful message,
> without being specific:
> 
> 	test=> set effective_io_concurrency = 1;
> 	ERROR:  parameter "effective_io_concurrency" cannot be changed from 0
I fixed this an easier way, by making the parameter PGC_INTERNAL on
systems that don't have posix_fadvise().
-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com
  + If your life is a hard drive, Christ can be your backup. +
| Attachment | Content-Type | Size | 
|---|---|---|
| /rtmp/diff | text/x-diff | 1.0 KB | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2009-04-02 19:58:37 | Re: Crash in gist insertion on pathological box data | 
| Previous Message | Tom Lane | 2009-04-02 19:49:59 | Re: [COMMITTERS] pgsql: If we expect a hash join to be performed in multiple batches, |