Re: typedefs for indent

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Frankly, I don't remember anyone complaining we didn't find any typedefs
> > in pgindent,
>
> There are lots and lots of places where it's obvious that pgindent
> was misinformed on the subject, because it puts in a space where there
> should not be one, eg "typename * ptr" instead of "typename *ptr".
> Maybe I'm just being too anal in worrying about a space here or a space
> there ... but then why do we run the thing at all?

Sure, why not make it as good as we can.

> This is the first time I've heard anyone suggest that false positives
> could be a problem. What exactly would be the results of a false
> match? Would it look worse than the false negatives do?

Well, I assume a false positive would do the opposite, meaning it would
not have a space where it should have one. I am also worried about a
typedef list that changes from release to release as buildfarm members
change; variability might be worse than correctness in this case.

Anyway, I think a diff of using my list and Andrew's list will show us
which one gets things clearest; the diff is going to highlight only
cases where the typedef lists change formatting.

Andrew, where exactly is the list I should try?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +