Re: AIX 4.3 getaddrinfo busted

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andrew Chernow <ac(at)esilo(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: AIX 4.3 getaddrinfo busted
Date: 2009-01-23 14:21:42
Message-ID: 200901231421.n0NELgN19695@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Chernow wrote:
> AIX 4.3 was released in late 1999, so I thought it was worth mentioning.
> I only have AIX 4.3 and 6.1, so I have no idea how AIX 5 handles this.
> AIX 6.1 works fine.
>
> Anyways, the service argument to getaddrinfo is busted on AIX 4.3, thus
> src/backend/libpq/ip.c pg_getaddrinfo_all() is busted on this
> platform. It fails with EAI_NODATA "Host not found". If this argument
> is left NULL, everything works.
>
> I can supply a patch to fix this. My suggestion would be to always
> supply a NULL service to getaddrinfo. After a successful call, set the
> port if it was provided ... htons((unsigned short)atoi(servname)). This
> approach avoids a configure check.

Why would we risk breaking other platforms to avoid an AIX bug? At best
we can put a code comment in that section of the code.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christopher Browne 2009-01-23 14:22:10 Re: AIX 4.3 getaddrinfo busted
Previous Message Andrew Chernow 2009-01-23 14:18:48 AIX 4.3 getaddrinfo busted