Re: libpq WSACleanup is not needed

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andrew Chernow <ac(at)esilo(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, James Mansion <james(at)mansionfamily(dot)plus(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: libpq WSACleanup is not needed
Date: 2009-01-20 16:47:06
Message-ID: 200901201647.n0KGl6017742@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Chernow wrote:
> Bruce Momjian wrote:
> > Andrew Chernow wrote:
> >> Bruce Momjian wrote:
> >>> Ah, OK, so it does its own cleanup on last close, great. I agree a
> >>> connection option for this would be good.
> >>>
> >> What would the option be? "wsainit = [enable | disable]"? Maybe it
> >> should allow setting the version to load: "wsa_version = 2.0". Maybe
> >> the two should be combined: "wsa_version = [default | disable | 2.0]".
> >
> > I assumed it would be like SSL, which is a libpq function call, not a
> > connection option, e.g. PQinitSSL(), and I think true/false is probably
> > enough. PQinitSSL info:
> >
> > If you are using <acronym>SSL</> inside your application (in addition
> > to inside <application>libpq</application>), you can use
> > <function>PQinitSSL(int)</> to tell <application>libpq</application>
> > that the <acronym>SSL</> library has already been initialized by your
> > application.
> >
>
> That smells dirty to me. How many PQinitXXX() functions are needed
> before we drop the XXX and run with PQinit(...)?

Odds are you would still need per-library control over initialization so
I am not sure that helps, i.e. the library initialized WSA already but
needs SSL.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2009-01-20 16:49:51 Re: visibility maps and heap_prune
Previous Message Andrew Chernow 2009-01-20 16:42:54 Re: libpq WSACleanup is not needed