Re: SnapshotResetXmin

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SnapshotResetXmin
Date: 2009-01-16 16:37:14
Message-ID: 20090116163714.GB12449@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Simon Riggs wrote:
>
> SnapshotResetXmin is called 3 times after each statement in
> ReadCommitted mode.
>
> Too keen, perhaps?

It is called each time a snapshot is unregistered and each time an
active snapshot is popped. I don't see any way to reduce the number of
calls without complicating the code a lot ... do you have any ideas?

Maybe we could check whether TransState is not TRANS_INPROGRESS and skip
it in those cases ...?

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2009-01-16 16:52:20 GetCurrentVirtualXIDs()
Previous Message Tom Lane 2009-01-16 16:36:45 Re: FWD: Re: Updated backslash consistency patch