| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
| Cc: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>, pgsql-hackers(at)postgresql(dot)org, KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, bruce(at)momjian(dot)us, tgl(at)sss(dot)pgh(dot)pa(dot)us, simon(at)2ndQuadrant(dot)com |
| Subject: | Re: Updates of SE-PostgreSQL 8.4devel patches (r1403) |
| Date: | 2009-01-14 11:44:23 |
| Message-ID: | 20090114114423.GA24156@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Martijn van Oosterhout wrote:
> On Tue, Jan 13, 2009 at 10:05:45AM -0300, Alvaro Herrera wrote:
> > pgace.h: you have a bunch of "static inline" functions in here. As far
> > as I know this doesn't work in compilers other than GCC :-( See
> > pg_list.h (list_head) for an example. I think we can tolerate this for
> > the three functions in pg_list.h because they are so few and so tiny,
> > but I'm not sure about PGACE because they are a large lot. On the other
> > hand, turning them to real functions would be a performance hit.
>
> Really? C99 requires it and MSVC does support it.
Apparently we're stuck with C89 for some time yet; maybe an upgrade can
be argued, if a large gain by the jump to C99 can be demonstrated:
http://archives.postgresql.org/pgsql-hackers/2008-11/msg01494.php
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Verite | 2009-01-14 12:07:51 | Re: inconsistency in aliasing |
| Previous Message | Scott Marlowe | 2009-01-14 11:41:40 | Re: inconsistency in aliasing |