Re: [PATCH] Check operator when creating unique index on partition table

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Guancheng Luo <prajnamort(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Check operator when creating unique index on partition table
Date: 2020-04-01 18:53:09
Message-ID: 20082.1585767189@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Guancheng Luo <prajnamort(at)gmail(dot)com> writes:
> On Mar 26, 2020, at 01:00, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> This would reject, for example, a hash index associated with a btree-based
>> partition constraint, but I'm not sure we're losing anything much thereby.

> There is cases when a BTREE index associated with a HASH partition key, but I think we should allow them,
> as long as their equality operators consider the same value as equal.

Ah, yeah, I see we already have regression test cases that require that.

I pushed the patch with some cosmetic revisions. I left out the
regression test case though; it seemed pretty expensive considering
that the code is already being exercised by existing cases.

Thanks for the report and patch!

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2020-04-01 18:54:43 Re: tweaking perfect hash multipliers
Previous Message Julien Rouhaud 2020-04-01 18:47:12 Re: BUG #16109: Postgres planning time is high across version (Expose buffer usage during planning in EXPLAIN)