| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Snapshot warning |
| Date: | 2008-11-25 19:30:18 |
| Message-ID: | 20081125193018.GP4875@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane escribió:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > After the patch we don't have any way to detect whether resowner.c has
> > any snapshot still linked to. I assume there's no objection to adding a
> > new entry point in resowner.c for this.
>
> Hmm, that's a bit problematic because resowner.c doesn't have any global
> notion of what resource owners exist. I think you still need to have
> snapmgr.c maintain a list of all known snapshots. resowner.c can only
> help you with tracking reference counts for particular snapshots.
A counter seems to suffice. Patch attached.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| Attachment | Content-Type | Size |
|---|---|---|
| resowner-snaps.patch | text/x-diff | 18.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-11-25 19:37:01 | Re: Snapshot warning |
| Previous Message | Ron Mayer | 2008-11-25 19:29:27 | Re: blatantly a bug in the documentation |