| From: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: auto_explain contrib moudle |
| Date: | 2008-11-15 01:20:00 |
| Message-ID: | 20081115101533.FDCC.52131E4D@oss.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Now that I look closer, the "contrib infrastructure" item is just a
> combination of the auto_explain and pg_stat_statements items, and I
> guess the reason you and Matthew were shown as reviewers was that
> you'd each been assigned one of those two items. As far as I can see
> this is just confusing and duplicative.
That's right. Sorry for your confusing.
> I think we can
> proceed with the two other items separately. If there's any conflict
> in the two patches we can resolve it after the first one gets applied.
contrib/auto_explain patch is "Ready for committer" even without
the QueryDesc patch. So please apply it if there are no problems.
I'll rewrite contrib/pg_stat_statements to use the new feature
in the QueryDesc patch and avoid confliction from the first one.
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2008-11-15 01:24:00 | Re: "ORDER BY" clause prevents "UPDATE WHERE CURRENT OF" |
| Previous Message | Robert Haas | 2008-11-15 01:18:19 | Re: "ORDER BY" clause prevents "UPDATE WHERE CURRENT OF" |