Re: [I|S]CONST/[I|S]const in gram.y

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, PostgreSQL Hacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [I|S]CONST/[I|S]const in gram.y
Date: 2008-11-10 14:35:44
Message-ID: 20081110143544.GA8145@feivel.credativ.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 10, 2008 at 08:12:49AM -0500, Tom Lane wrote:
> Which direction are you hoping to go --- remove Iconst/Sconst, or use
> them everywhere?

For ecpg I don't care, I have to make some changes during translation anyway.
Right now my script just sets both to ecpg_iconst. There is a small advantage
in keeping Iconst/Sconst as it might save me a line or two in the script. As
for the backend I would say that removing Iconst/Sconst make sense. These rules
just add an overhead, albeit a very small one. But still this advantage
outweighs the very small scripting advantage. So yes, I'd remove Iconst/Sconst.

Michael

--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Meskes 2008-11-10 14:40:50 gram.y=>preproc.y
Previous Message Ron Mayer 2008-11-10 14:26:04 Re: Patch for ISO-8601-Interval Input and output.