From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Euler Taveira de Oliveira <euler(at)timbira(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: autovacuum and reloptions |
Date: | 2008-10-15 22:46:30 |
Message-ID: | 20081015224630.GI6012@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Euler Taveira de Oliveira wrote:
> Alvaro Herrera escreveu:
>
> > Maybe we could add a "category" bitmask for which each option would be
> > valid.
> >
> The category tests are fine, that's why I introduced relopt_gen.kind but
> I'm not using it yet.
Ah, right, I hadn't noticed the kind stuff, maybe because it's unused
;-)
> I'll try to refactor it to use bitmask (some options could be used to
> both -- fillfactor) and to add it in the validation code.
Right, that's why I suggested using a bitmask.
Okay, so I'll let you deal with this for a while yet. A minor
suggestion: label the enum members distinctively, i.e. instead of
RO_BOOL perhaps use RELOPT_TYPE_BOOL, and RO_HEAP should be
RELOPT_KIND_HEAP (note this cannot be a plain enum, each category needs
a separate bit).
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Stark | 2008-10-15 22:52:20 | Re: Is autovacuum too noisy about orphan temp tables? |
Previous Message | Tom Lane | 2008-10-15 21:30:27 | Re: The Axe list |