From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Volkan YAZICI <yazicivo(at)ttmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Verbosity of Function Return Type Checks |
Date: | 2008-09-09 15:16:06 |
Message-ID: | 20080909151606.GD4223@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Volkan YAZICI wrote:
> On Mon, 8 Sep 2008, Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> >> Modified as you suggested. BTW, will there be a similar i18n scenario
> >> for "dropped column" you mentioned below?
> >
> > Yes, you need _() around those too.
>
> For this purpose, I introduced a dropped_column_type variable in
> validate_tupdesc_compat() function:
>
> const char dropped_column_type[] = _("n/a (dropped column)");
>
> And used this in below fashion:
>
> OidIsValid(returned->attrs[i]->atttypid)
> ? format_type_be(returned->attrs[i]->atttypid)
> : dropped_column_type
I changed it to gettext_noop("the text") and _(dropped_column_type) in
errdetail, and committed it.
I'd still like to have a better way to word the message, and maybe have
this error appear in a regression test somewhere at least once ...
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Davis | 2008-09-09 15:21:33 | Re: Common Table Expressions (WITH RECURSIVE) patch |
Previous Message | Tatsuo Ishii | 2008-09-09 15:12:58 | Re: Common Table Expressions (WITH RECURSIVE) patch |