Re: [PATCHES] libpq events patch (with sgml docs)

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Andrew Chernow <ac(at)esilo(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Merlin Moncure <mmoncure(at)gmail(dot)com>
Subject: Re: [PATCHES] libpq events patch (with sgml docs)
Date: 2008-09-05 20:15:04
Message-ID: 20080905201504.GM4353@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Chernow escribió:
> Alvaro Herrera wrote:
>> Andrew Chernow escribió:

>>> * PQclear -
>>> * free's the memory associated with a PGresult
>>> */
>>
>> I'd add a comment here stating why the event name is not deallocated;
>> otherwise it just looks like it's being leaked.
>
> The event name is being deallocated.

Doh! Sorry, you're right. In that case, you're missing a NULL result
check from strdup() in dupEvents() ;-)

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alex Hunsaker 2008-09-05 20:21:36 Re: hash index improving v3
Previous Message David Rowley 2008-09-05 20:13:58 Re: [HACKERS] TODO item: Implement Boyer-Moore searching (First time hacker)

Browse pgsql-patches by date

  From Date Subject
Next Message Alex Hunsaker 2008-09-05 20:21:36 Re: hash index improving v3
Previous Message David Rowley 2008-09-05 20:13:58 Re: [HACKERS] TODO item: Implement Boyer-Moore searching (First time hacker)