Re: pgsql: Make the pg_stat_activity view call a SRF

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make the pg_stat_activity view call a SRF
Date: 2008-08-16 03:49:37
Message-ID: 200808160349.m7G3nbr10695@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Magnus Hagander wrote:
> Bruce Momjian wrote:
> > Magnus Hagander wrote:
> >>> Sure, see pg_timezone_abbrevs(), pg_timezone_names().
> >>>
> >>> (This only started to work recently, which is why we have so many
> >>> record-returning functions that don't do it that way. It might be
> >>> an idea to fix them all sooner or later.)
> >> Wow, that was easy. Not sure where I got the impression it was hard
> >> from - probably last looked at it before it was made easy, and didn't
> >> re-check :-)
> >>
> >> Updated the pg_stat_get_activity() function to use this.
> >>
> >> And yes, I agree that it's probably a very good idea to go over our
> >> other SRFs and fix them all. I can take a look at that eventually, but
> >> for now I think we stick it on the TODO?
> >
> > Added to TODO:
> >
> > * Fix system views like pg_stat_all_tables to use set-returning
> > functions, rather than views of per-column functions
>
> Thanks, and while I approve of that TODO, that's not actually the one I
> was talking about in the email. The one I was talking about was "change
> builtin set-returning functions to use OUT parameters so you can query
> them without knowing the result format" or something like that.
>
> So, please keep the one you added, but add this one as well.

Uh, I need more details on this. Can you give an example?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-08-16 05:03:43 Re: pgsql: Make the pg_stat_activity view call a SRF
Previous Message User Jbcooley 2008-08-16 03:35:08 npgsql - Npgsql2: added support for uuid type

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Raney 2008-08-16 04:15:53 Re: Explain XML patch submitted
Previous Message Bosco Rama 2008-08-16 03:47:49 ecpg 'set' failure using host vars