Re: Re: [COMMITTERS] pgsql: Add column storage type to psql \d+ display.

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Add column storage type to psql \d+ display.
Date: 2008-07-18 03:35:57
Message-ID: 20080718033557.GT3934@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Bruce Momjian wrote:
> Alvaro Herrera wrote:

> > I think this patch has caused this new warning in psql:
> >
> > /pgsql//source/00head/src/bin/psql/describe.c: In function ?describeOneTableDetails?:
> > /pgsql//source/00head/src/bin/psql/describe.c:832: warning: ?tableinfo.relkind? may be used uninitialized in this function
>
> I don't see that warning with my compiler so I have no way of testing
> this, but I do see this line pretty high in the function:
>
> tableinfo.relkind = *(PQgetvalue(res, 0, 1));

But it's before the first "goto error_return", after which it is checked.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-07-18 04:20:24 pgsql: Suppress compiler warning, and not incidentally make the code
Previous Message Tom Lane 2008-07-18 03:33:58 Re: pgsql: Support "variadic" functions, which can accept a variable number

Browse pgsql-hackers by date

  From Date Subject
Next Message Gurjeet Singh 2008-07-18 03:46:15 Load spikes on 8.1.11
Previous Message Bruce Momjian 2008-07-18 02:20:25 Re: [COMMITTERS] pgsql: Add column storage type to psql \d+ display.