Re: [PATCHES] WITH RECURSIVE updated to CVS TIP

From: David Fetter <david(at)fetter(dot)org>
To: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Cc: y-asaba(at)sraoss(dot)co(dot)jp, postgres(at)cybertec(dot)at, pgsql-patches(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] WITH RECURSIVE updated to CVS TIP
Date: 2008-07-16 01:57:38
Message-ID: 20080716015738.GN5623@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Wed, Jul 16, 2008 at 09:37:25AM +0900, Tatsuo Ishii wrote:
> > On Tue, Jul 08, 2008 at 06:01:05PM +0900, Tatsuo Ishii wrote:
> > > Here is the patches he made against CVS HEAD (as of today).
> > >
> > > According to him followings are fixed with the patches:
> > >
> > > - fix crush with DISTINCT
> > > - fix creating VIEW
> > > - fix the case when recursion plan has another recursion plan under it
> > > - fix WITH RECURSIVE ...(..) SELECT ...WHERE.. returns wrong result
> > > - fix inifinit recursion with OUTER JOIN
> >
> > Great!
> >
> > I've patched psql for some partial support of WITH [RECURSIVE].
> >
> > http://git.postgresql.org/?p=~davidfetter/postgresql/.git;a=commit;h=da63f9a82b9e902b5542f788b2e6e6bc95221793
>
> Thanks. I will incorporate them with propsed patches.

Part of the point of this exercise is to make git the way to do this.
Can you please point me to a git repository where your latest changes
are so I can publish them?

> > > Not yet fixed:
> > >
> > > - detect certain queries those are not valid acroding to the standard
> > > - sort query names acording to the dependency
> >
> > Is there something in the standard on how to do this? How to sort
> > the nodes other ways?
>
> No idea. What do you think if we allow only one query name at the
> moment.

I'm not sure I understand what that has to do with sorting.

Please find attached a place where I've found some problems sorting by
tree by array as Asaba-san suggested.

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Attachment Content-Type Size
region_tree.sql text/plain 11.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message ITAGAKI Takahiro 2008-07-16 02:49:13 Re: [PATCHES] WIP: executor_hook for pg_stat_statements
Previous Message Bruce Momjian 2008-07-16 01:20:59 Re: rfc: add pg_dump options to dump output

Browse pgsql-patches by date

  From Date Subject
Next Message ITAGAKI Takahiro 2008-07-16 02:49:13 Re: [PATCHES] WIP: executor_hook for pg_stat_statements
Previous Message Tom Lane 2008-07-16 01:51:25 Re: variadic function support