From: | daveg <daveg(at)sonic(dot)net> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Alex Hunsaker <badalex(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Patches <pgsql-patches(at)postgresql(dot)org>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Greg Sabino Mullane <greg(at)turnstep(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout |
Date: | 2008-06-23 23:17:35 |
Message-ID: | 20080623231735.GB2004@sonic.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
On Mon, Jun 23, 2008 at 06:51:28PM -0400, Bruce Momjian wrote:
> Alex Hunsaker wrote:
> > On Wed, Apr 16, 2008 at 4:54 PM, Alvaro Herrera
> > <alvherre(at)commandprompt(dot)com> wrote:
> > > Joshua D. Drake escribi?:
> > >
> > > > That is an interesting idea. Something like:
> > > >
> > > > pg_restore -E "SET STATEMENT_TIMEOUT=0; SET MAINTENANCE_WORK_MEM=1G" ?
> > >
> > > We already have it -- it's called PGOPTIONS.
> > >
> >
> > Ok but is not the purpose of the patch to turn off statement_timeout
> > by *default* in pg_restore/pg_dump?
> >
> > Here is an updated patch for I posted above (with the command line
> > option --use-statement-timeout) for pg_dump and pg_restore.
>
> I would like to get do this without adding a new --use-statement-timeout
> flag. Is anyone going to want to honor statement_timeout during
> pg_dump/pg_restore? I thought we were just going to disable it.
I have a patch in the queue to use set statement timeout while pg_dump is
taking locks to avoid pg_dump hanging for other long running transactions
that may have done ddl. Do I need to repost for discussion now?
-dg
--
David Gould daveg(at)sonic(dot)net 510 536 1443 510 282 0869
If simplicity worked, the world would be overrun with insects.
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2008-06-23 23:30:53 | Re: [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout |
Previous Message | Tom Lane | 2008-06-23 23:09:11 | Re: Dept of ugly hacks: eliminating padding space in system indexes |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2008-06-23 23:30:53 | Re: [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout |
Previous Message | Bruce Momjian | 2008-06-23 22:59:01 | Re: [PATCHES] Testing pg_terminate_backend() |