Re: ERRORDATA_STACK_SIZE panic crashes on Windows

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: ERRORDATA_STACK_SIZE panic crashes on Windows
Date: 2008-05-27 19:09:16
Message-ID: 20080527210916.3487e0e3@mha-laptop.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> Magnus Hagander wrote:
> > > 2. Adjust the AC_SEARCH_LIBS call to probe for
> > > bind_textdomain_codeset() instead of gettext() as it does now.
> > > This would have the effect of rejecting pre-0.10.36 versions of
> > > the library.
> >
> > Depending on the buildfarm issue it may be that the software is
> > antique enough that almost only Bruce runs such an old version. If
> > so, I think #2 is just fine (except in back branches, of course)
>
> You don't have to fix it just for me --- I can remove --enable-nls;
> the big question is who else is going to hit this. I think the
> buildfarm has safe-enough checking for 8.4, but I am concerned about
> the back branches where testing isn't as complete.

This is why I'm suggesting the #ifdef WIN32 for back branches.

//Magnus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomasz Rybak 2008-05-27 19:14:23 BUG #4204: COPY to table with FK has memory leak
Previous Message Bruce Momjian 2008-05-27 19:05:14 Re: ERRORDATA_STACK_SIZE panic crashes on Windows