Re: What in the world is happening on spoonbill?

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, pgsql-hackers(at)postgresql(dot)org, Michael Meskes <meskes(at)postgresql(dot)org>
Subject: Re: What in the world is happening on spoonbill?
Date: 2008-05-19 08:40:15
Message-ID: 20080519084015.GB22818@feivel.credativ.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, May 17, 2008 at 03:52:07PM -0400, Tom Lane wrote:
> So I coded this up, and fortunately thought to try it with ecpg's tests
> before committing:
> ...
> test preproc/whenever ... FAILED: test process exited with exit code 1
> ...
> Apparently the exit(1) is intentional in that test.
> ..
> work than it's worth. Would it be all right to just remove the test of
> "on error stop" mode?

I'm fine with removing this test. Granted it leaves a very small code
path untested but I think we can live with this.

Michael
--
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Martijn van Oosterhout 2008-05-19 08:42:23 Re: [HACKERS] WITH RECURSIVE patch V0.1
Previous Message Hannu Krosing 2008-05-19 07:46:18 Re: notification information functions