Re: win32mak_patch

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: win32mak_patch
Date: 2008-04-27 16:49:40
Message-ID: 20080427184940.15d96b6b@mha-laptop.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

The changes except the one to exports.txt look ok.

Why do you need to export pgwin32_safestat? It's *not* exported when
you build with mingw or the automated msvc build, and nothing breaks
there. Who is trying to use it?

//Magnus

Hiroshi Saito wrote:
> Hi.
>
> Oops, Certainly.
> I propose the method of merging by distprep as exports.txt.win32.
> What do you think?
>
> Regards,
> Hiroshi Saito
>
> ----- Original Message -----
> From: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
>
>
> > "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> writes:
> >> *** src/interfaces/libpq/exports.txt.orig Sun Apr 27 23:41:51 2008
> >> --- src/interfaces/libpq/exports.txt Sun Apr 27 23:42:48 2008
> >> ***************
> >> *** 141,143 ****
> >> --- 141,144 ----
> >> pg_valid_server_encoding_id 139
> >> PQconnectionNeedsPassword 140
> >> lo_import_with_oid 141
> >> + pgwin32_safestat 142
> >
> >
> > We are most certainly NOT doing that (for one reason, it will
> > instantly break every platform except Windows). If there is
> > something that seems to require it then you need to find another
> > way.
> >
> > regards, tom lane
>
> --
> Sent via pgsql-patches mailing list (pgsql-patches(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-patches

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Hiroshi Saito 2008-04-27 17:00:26 Re: win32mak_patch
Previous Message Hiroshi Saito 2008-04-27 16:38:38 Re: win32mak_patch