| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | NikhilS <nikkhils(at)gmail(dot)com>, Brendan Jurd <direvus(at)gmail(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gregory Stark <stark(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Lessons from commit fest |
| Date: | 2008-04-16 16:39:42 |
| Message-ID: | 200804161639.m3GGdgc06624@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Magnus Hagander wrote:
> > And I think adopting surrounding naming, commeting, coding conventions
> > should come naturally as it can aide in copy-pasting too :)
>
> I think pg_indent has to be made a lot more portable and easy to use
> before that can happen :-) I've run it once or twice on linux machines,
> and it comes out with huge changes compared to what Bruce gets on his
> machine. Other times, it doesn't :-) So yeah, it could be that it just
> needs to be made easier to use, because I may certainly have done
> something wrong.
Agreed, pgindent is too cumbersome to require patch submitters to use.
One idea would be to allow C files to be emailed and the indented
version automatically returned via email.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-04-16 16:46:38 | Re: pg_terminate_backend() issues |
| Previous Message | Bruce Momjian | 2008-04-16 16:36:50 | Re: Lessons from commit fest |