pgsql: Defend against JOINs having more than 32K columns altogether.

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Defend against JOINs having more than 32K columns altogether.
Date: 2008-04-05 01:59:01
Message-ID: 20080405015901.318DE7558E7@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Defend against JOINs having more than 32K columns altogether. We cannot
currently support this because we must be able to build Vars referencing
join columns, and varattno is only 16 bits wide. Perhaps this should be
improved in future, but considering that it never came up before, I'm not
sure the problem is worth much effort. Per bug #4070 from Marcello
Ceschia.

The problem seems largely academic in 8.0 and 7.4, because they have
(different) O(N^2) performance issues with such wide joins, but
back-patch all the way anyway.

Tags:
----
REL7_4_STABLE

Modified Files:
--------------
pgsql/src/backend/parser:
parse_relation.c (r1.90.2.2 -> r1.90.2.3)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_relation.c?r1=1.90.2.2&r2=1.90.2.3)
pgsql/src/include/access:
attnum.h (r1.17 -> r1.17.4.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/access/attnum.h?r1=1.17&r2=1.17.4.1)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2008-04-05 02:26:14 pgsql: Re-add dblink_current_query() for backward compatibility.
Previous Message Tom Lane 2008-04-05 01:58:52 pgsql: Defend against JOINs having more than 32K columns altogether.