Re: gcc 4.3 breaks ContribCheck in 8.2 and older.

From: Kurt Roeckx <kurt(at)roeckx(dot)be>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: gcc 4.3 breaks ContribCheck in 8.2 and older.
Date: 2008-03-24 19:03:56
Message-ID: 20080324190356.GA5231@roeckx.be
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 24, 2008 at 02:52:18PM -0400, Tom Lane wrote:
> Kurt Roeckx <kurt(at)roeckx(dot)be> writes:
> > 8.2 and 8.3 actually get the same value in fmgr_oldstyle(), it just
> > seems they do something else with it somewhere else.
>
> Doh. I'll bet the difference is this fix:
>
> http://archives.postgresql.org/pgsql-committers/2007-07/msg00131.php
>
> Please try that patch and see what it fixes pre-8.3.

No, returnValue contains the same value for both 8.2 and 8.3. There is
no reason why casting from a char * to a char * should result into
something else.

Kurt

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2008-03-24 19:04:39 Re: New email list for emergency communications
Previous Message Joshua D. Drake 2008-03-24 19:01:12 Re: New email list for emergency communications