Re: Autovacuum vs statement_timeout

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>, pgsql-hackers(at)postgresql(dot)org, "Jim C(dot) Nasby" <jim(at)nasby(dot)net>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: Autovacuum vs statement_timeout
Date: 2008-03-11 15:40:05
Message-ID: 200803111540.m2BFe5p05915@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


I have added a TODO:

> o Set up autovacuum to ignore statement_timeout set in
> postgresql.conf
>
> http://archives.postgresql.org/pgsql-hackers/2007-03/msg01753.php

and documented this behavior with the attached patch; backpatched to 8.3.X.

---------------------------------------------------------------------------

Magnus Hagander wrote:
> On Tue, Apr 17, 2007 at 10:33:21PM -0400, Bruce Momjian wrote:
> > Alvaro Herrera wrote:
> > > I think that is too strong an assumption, which is why I'm planning to
> > > back-patch the change to reset statement_timeout to 0 on autovacuum till
> > > 8.0, as discussed. I think I should also backpatch the change to set
> > > zero_damaged_pages as well (which is not on 8.0 AFAIR).
> > >
> > > It's very very easy to change things in postgresql.conf. Actually
> > > knowing what you are doing (i.e. thinking on the consequences on VACUUM
> > > and such) is a whole another matter.
> >
> > Frankly, setting statement_timeout in postgresql.conf seems so risky in
> > so many ways, perhaps we just need to document that the parameter
> > probably should not be set in postgresql.conf, and why.
>
> I'd suggest doing both. Tell people that it's dangerous (probably to the
> point of a comment in the sample config file), but *also* force it in
> pg_dump since you can't really expect people to read the documentation.
>
> //MAgnus

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/rtmp/diff text/x-diff 740 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2008-03-11 15:44:00 Re: Background LRU Writer/free list
Previous Message Heikki Linnakangas 2008-03-11 15:21:04 Re: LISTEN vs. two-phase commit