| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: message string fixes |
| Date: | 2008-01-20 22:32:47 |
| Message-ID: | 20080120223247.GB24325@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Teodor Sigaev wrote:
>> aren't user-facing errors at all, and should be demoted to elog's,
>> correct?
>>
>> elog(ERROR, "invalid regis pattern: \"%s\"", str);
>
> Hmm. If regis detects an error in expression then it will be an error for
> regex library too. At least, it was supposed to be.
And those that are not, probably are not what the user intends anyway,
with the pattern language being so narrow.
If all invalid regis patterns are indeed invalid regex patterns, then
just changing "regis" for "regex" should be enough.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Cave-Ayland | 2008-01-20 22:52:23 | Re: Minor bug in src/port/rint.c |
| Previous Message | Pavel Stehule | 2008-01-20 22:20:13 | Re: proposal: generic function, constructor function |