Re: logger subprocess including win32

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Subject: Re: logger subprocess including win32
Date: 2004-08-05 18:53:23
Message-ID: 20080.1091732003@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Andreas Pflug <pgadmin(at)pse-consulting(dot)de> writes:
> Attached the patch, an orgy in #ifdefs, decorated with various indents
> and crlf line ends (glad we have pgindent).

I spent a fair amount of time fooling with this, trying to extract
something that I trusted enough to apply at this late date, but got
stuck on one point. Exiting when the postmaster dies is *not* good
enough; we want the logger to stick around until the last process
upstream of the logger pipe is gone. In the Unix case we can detect
this by watching for EOF on the pipe, but I don't know how to do the
equivalent in this threaded scheme you've devised for Windows.

(Why is the separate thread needed, again?)

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Andreas Pflug 2004-08-05 19:22:58 Re: Win32 tablespace
Previous Message Zhenbang Wei 2004-08-05 17:12:33 postgres-zh_TW.po for current