From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Dmitriy <im(at)ionflux(dot)ru>, pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: BUG #3841: core dump in uuid-ossp |
Date: | 2007-12-27 17:04:37 |
Message-ID: | 20071227170437.GM5709@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Please try the attached patch.
>
> Most of the invocations of pguuid_complain will be outright lies as to
> which function is complaining. Please rethink the error message.
Doh! Sorry. How about this:
static void
pguuid_complain(uuid_rc_t rc)
{
char *err = uuid_error(rc);
if (err != NULL)
ereport(ERROR,
(errmsg("OSSP uuid failure: %s", err)));
else
ereport(ERROR,
(errmsg("OSSP uuid failure: error code %d", rc)));
}
Alternatively we could pass the called function name into
pguuid_complain, but I'm not sure it's worth the trouble (what does it
give the user, anyway?)
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-12-27 18:51:11 | Re: BUG #3841: core dump in uuid-ossp |
Previous Message | Alvaro Herrera | 2007-12-27 16:55:47 | Re: Server does not start when log_statement_stats is set to on |