Skip site navigation (1) Skip section navigation (2)

Re: Server does not start when log_statement_stats is setto on

From: Alvaro Herrera <alvherre(at)CommandPrompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Devrim GÜNDÜZ <devrim(at)CommandPrompt(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Server does not start when log_statement_stats is setto on
Date: 2007-12-27 16:55:47
Message-ID: 20071227165547.GK5709@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-bugs
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)CommandPrompt(dot)com> writes:
> > I think this makes plenty of sense.  However, something that occured to
> > me just now is that perhaps the right thing to do in the long term is to
> > put this message in errcontext and leave the "invalid value for XXX" as
> > the main error message.  That would probably involve attaching a
> > errcontext callback and removing the complaint_level from this message
> > altogether, letting the outer caller deal with it.
> 
> errcontext wouldn't help --- by the time guc.c is ready to throw the
> error, the assign hook isn't in the call stack anymore.  We'd have to
> invent some other special-purpose gizmo to make this work.
> 
> Might be worth doing, but again, seems too big a change for 8.3.

Right -- your proposed fix seems fine for 8.3.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

pgsql-bugs by date

Next:From: Alvaro HerreraDate: 2007-12-27 17:04:37
Subject: Re: BUG #3841: core dump in uuid-ossp
Previous:From: Tom LaneDate: 2007-12-27 15:25:13
Subject: Re: Server does not start when log_statement_stats is set to on

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group