Re: [PATCH] automatic integer conversion

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: xeb(at)mail(dot)ru
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCH] automatic integer conversion
Date: 2007-12-08 20:53:56
Message-ID: 20071208205356.GA13665@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

xeb(at)mail(dot)ru wrote:
> Hello!
> Here is patch which makes libpq more confortable when working with binary integers.
> Automatic conversion intialized by PQsetconvertint(conn,1), so old
> applications continues to work proper.

This seems to depend on <byteswap.h> which doesn't look like a portable
interface.

Please note that I'm not saying that fixing that issue means the patch
is acceptable. Personally I'm not sure that this is a worthy goal you
are pursuing here. Wouldn't it be a good idea to propose the feature
first and write the code later?

--
Alvaro Herrera http://www.amazon.com/gp/registry/DXLWNGRJD34J
"Aprender sin pensar es inútil; pensar sin aprender, peligroso" (Confucio)

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-12-08 23:35:46 Patch for PQconnectionUsedPassword brain-damage
Previous Message Magnus Hagander 2007-12-08 20:11:36 Re: buildenv.pl/buildenv.bat