Re: type money causes unrestorable dump

From: "D'Arcy J(dot)M(dot) Cain" <darcy(at)druid(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: type money causes unrestorable dump
Date: 2007-11-03 19:42:08
Message-ID: 20071103154208.36ebc82a.darcy@druid.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, 03 Nov 2007 14:39:48 -0400
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "D'Arcy J.M. Cain" <darcy(at)druid(dot)net> writes:
> > I never received a response on this. Here is the full diff with the
> > above change. Since it is documentation and not code, is it OK to
> > commit this now?
>
> The added text needs some copy-editing, I think. How about
>
> Since the output of this data type is locale-sensitive, it may not
> work to load <type>money</> data into a database that has a different
> setting of <varname>lc_monetary</>. To avoid problems, before
> restoring a dump make sure <varname>lc_monetary</> has the same value
> as in the database that was dumped.
>
> (Actually, the first of the two lc_monetary references should be
> an xref link to the GUC variable, but I'm too lazy to type that out.)
>
> A more direct approach to the problem might be to change pg_dump to
> set lc_monetary, as it does for client_encoding ...

Certainly OK by me.

--
D'Arcy J.M. Cain <darcy(at)druid(dot)net> | Democracy is three wolves
http://www.druid.net/darcy/ | and a sheep voting on
+1 416 425 1212 (DoD#0082) (eNTP) | what's for dinner.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-11-03 19:47:03 Re: [HACKERS] Text <-> C string
Previous Message Tom Lane 2007-11-03 19:27:10 CREATE CONSTRAINT TRIGGER compatibility issue