pgsql: Remove the aggregate form of ts_rewrite(), since it doesn't work

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove the aggregate form of ts_rewrite(), since it doesn't work
Date: 2007-10-24 02:24:49
Message-ID: 20071024022449.B9761754229@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Remove the aggregate form of ts_rewrite(), since it doesn't work as desired
if there are zero rows to aggregate over, and the API seems both conceptually
and notationally ugly anyway. We should look for something that improves
on the tsquery-and-text-SELECT version (which is also pretty ugly but at
least it works...), but it seems that will take query infrastructure that
doesn't exist today. (Hm, I wonder if there's anything in or near SQL2003
window functions that would help?) Per discussion.

Modified Files:
--------------
pgsql/doc/src/sgml:
textsearch.sgml (r1.24 -> r1.25)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/textsearch.sgml?r1=1.24&r2=1.25)
pgsql/src/backend/utils/adt:
tsquery_rewrite.c (r1.5 -> r1.6)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/tsquery_rewrite.c?r1=1.5&r2=1.6)
pgsql/src/include/catalog:
catversion.h (r1.436 -> r1.437)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/catversion.h?r1=1.436&r2=1.437)
pg_aggregate.h (r1.63 -> r1.64)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_aggregate.h?r1=1.63&r2=1.64)
pg_proc.h (r1.476 -> r1.477)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_proc.h?r1=1.476&r2=1.477)
pgsql/src/include/tsearch:
ts_type.h (r1.6 -> r1.7)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/tsearch/ts_type.h?r1=1.6&r2=1.7)
pgsql/src/test/regress/expected:
tsearch.out (r1.5 -> r1.6)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/tsearch.out?r1=1.5&r2=1.6)
pgsql/src/test/regress/sql:
tsearch.sql (r1.3 -> r1.4)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/tsearch.sql?r1=1.3&r2=1.4)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-10-24 03:30:03 pgsql: Set read_only = TRUE while evaluating input queries for
Previous Message Tom Lane 2007-10-23 21:38:16 pgsql: Make configure probe for the location of the <uuid.h> header