Re: ecpg thread-safe descriptor

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-patches(at)postgresql(dot)org
Subject: Re: ecpg thread-safe descriptor
Date: 2007-10-02 19:42:30
Message-ID: 20071002194230.GC25206@feivel.credativ.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Tue, Oct 02, 2007 at 08:22:21PM +0200, Magnus Hagander wrote:
> There are two problems:
> 1) DllMain breaks the build *completely*. This is the really urgent one.
> This one broke 2 days ago or so.
>
> 2) Regression tests don't pass on MSVC anymore. This broke a while ago.
> I was working on fixing this, but now that the build is broken there
> isn't much I can do until that's fixed.

When did they break? I'm still confused. Did we run regression tests at
all before? Or did they never work and we just didn't notice because the
buildfarm didn't run them?

> Also, see
> http://archives.postgresql.org/pgsql-hackers/2007-10/msg00006.php for
> another comment on this. This changes more than just the threading
> stuff, but if it's something we want then this is a good time to do it.

So, does an explicit export list help? If so I'm all for it. There is no
need to export all symbols. I always tried to keep the number of symbols
that get exported but are not needed low. So this will give the best
result possible.

Michael
--
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2007-10-02 19:50:15 Re: ecpg thread-safe descriptor
Previous Message Michael Meskes 2007-10-02 19:36:38 Re: ecpg thread-safe descriptor