Re: tsearch filenames unlikes special symbols and numbers

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Gregory Stark <stark(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: tsearch filenames unlikes special symbols and numbers
Date: 2007-09-03 07:56:09
Message-ID: 20070903075609.GD21833@svr2.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

On Mon, Sep 03, 2007 at 07:47:14AM +0100, Gregory Stark wrote:
> "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>
> > Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> >> "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> >>> I made it reject all but latin letters, which is the same restriction
> >>> that's in place for timezone set filenames. That might be overly
> >>> strong, but we definitely have to forbid "." and "/" (and "\" on
> >>> Windows). Do we want to restrict it to letters, digits, underscore?
> >>> Or does it need to be weaker than that?
> >
> >> What's the problem with "."?
> >
> > ../../../../etc/passwd
> >
> > Possibly we could allow '.' as long as we forbade /,
>
> Right, traditionally the only characters forbidden in filenames in Unix are /
> and nul. If we want the files to play nice in Gnome etc then we should
> restrict them to ascii since we don't know what encoding the gui expects.
>
> Actually I think in Windows \ : and . are problems (not allowed more than one
> dot in dos).

\ and : are problems.

. is not a problem. We don't support 16-bit windows anyway, and multiple
dots works fine on any system we support.

//Magnus

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Tom Lane 2007-09-03 13:27:19 Re: tsearch filenames unlikes special symbols and numbers
Previous Message Trevor Talbot 2007-09-03 07:26:09 Re: tsearch filenames unlikes special symbols and numbers

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2007-09-03 08:00:10 Re: [PATCH] Lazy xid assingment V2
Previous Message Marko Kreen 2007-09-03 07:55:24 Re: Per-function search_path => per-function GUC settings