| From: | tgl(at)postgresql(dot)org (Tom Lane) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Fix incorrect comment about the timing of AbsorbFsyncRequests() |
| Date: | 2007-07-03 14:51:24 |
| Message-ID: | 20070703145124.7B2409FB452@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Log Message:
-----------
Fix incorrect comment about the timing of AbsorbFsyncRequests() during
checkpoint. The comment claimed that we could do this anytime after
setting the checkpoint REDO point, but actually BufferSync is relying
on the assumption that buffers dumped by other backends will be fsync'd
too. So we really could not do it any sooner than we are doing it.
Modified Files:
--------------
pgsql/src/backend/postmaster:
bgwriter.c (r1.40 -> r1.41)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/bgwriter.c.diff?r1=1.40&r2=1.41)
pgsql/src/backend/storage/smgr:
md.c (r1.128 -> r1.129)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/smgr/md.c.diff?r1=1.128&r2=1.129)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | User Pgunittest | 2007-07-03 21:00:54 | pgunittest - pgUnitTest: New Directory |
| Previous Message | Fabien COELHO | 2007-07-03 07:53:28 | Re: [COMMITTERS] pgsql: Fix PGXS conventions so that extensions can be built against |