From: | alvherre(at)postgresql(dot)org (Alvaro Herrera) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Avoid passing zero as a value for vacuum_cost_limit, because it's |
Date: | 2007-06-08 21:09:49 |
Message-ID: | 20070608210949.52B839FB636@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
Avoid passing zero as a value for vacuum_cost_limit, because it's not a valid
value for the vacuum code. Instead, make zero signify getting the value from a
higher level configuration facility, just like -1 in the original coding. We
still document that -1 is the value that disables the feature, to avoid
confusing the user unnecessarily.
Reported by Galy Lee in <200705310914(dot)l4V9E6JA094603(at)wwwmaster(dot)postgresql(dot)org>;
per subsequent discussion.
Modified Files:
--------------
pgsql/doc/src/sgml:
catalogs.sgml (r2.153 -> r2.154)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/catalogs.sgml.diff?r1=2.153&r2=2.154)
pgsql/src/backend/postmaster:
autovacuum.c (r1.47 -> r1.48)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/autovacuum.c.diff?r1=1.47&r2=1.48)
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2007-06-08 21:21:28 | pgsql: Disallow the cost balancing code from resulting in a zero cost |
Previous Message | Tom Lane | 2007-06-08 20:26:18 | pgsql: Add note that LIMIT without ORDER BY can produce outright |