Autovacuum PGPROCs in ProcGlobal? (was Re: autovacuum multiworkers)

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-patches(at)postgresql(dot)org
Subject: Autovacuum PGPROCs in ProcGlobal? (was Re: autovacuum multiworkers)
Date: 2007-04-12 15:14:10
Message-ID: 20070412151410.GC15947@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Alvaro Herrera wrote:

> Oh, uh, the problem is that CreateSharedMemoryAndSemaphores wants to
> have access to the PGPROC already, but to obtain the PGPROC we need
> access to autovac shared memory (per AutoVacuumGetFreeProc). So this
> wasn't too bright a choice :-(

It seems like I'll have to decouple autovacuum PGPROC's from
autovacuum's own shared memory. The most sensible way to do this seems
to be to store them in ProcGlobal, along with the regular backend's
PGPROCs. Is everyone OK with this plan?

Note that this will mean that those PGPROCs will be protected by the
same spinlock that protects the other PGPROCs. I can't think of any
reason why this would be a problem, but if you think otherwise please
speak up.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Guido Neitzer 2007-04-12 15:19:57 Re: Slow Postgresql server
Previous Message Heikki Linnakangas 2007-04-12 15:12:30 Re: [HACKERS] Fix mdsync never-ending loop problem

Browse pgsql-patches by date

  From Date Subject
Next Message Guido Neitzer 2007-04-12 15:19:57 Re: Slow Postgresql server
Previous Message Heikki Linnakangas 2007-04-12 15:12:30 Re: [HACKERS] Fix mdsync never-ending loop problem