Re: non-recursive WITH clause support

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Gregory Stark <stark(at)enterprisedb(dot)com>, pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: non-recursive WITH clause support
Date: 2007-04-10 00:18:46
Message-ID: 20070410001846.GH27243@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Mon, Apr 09, 2007 at 06:43:08PM -0400, Tom Lane wrote:
> Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> > Here's an updated patch that fixes the bug I had. This is now functional basic
> > non-recursive WITH clause support.
> > http://community.enterprisedb.com/recursive/with-pg82stable-v2.patch.gz
> > It's a pretty short simple patch as is; it just directly inlines any WITH
> > clauses as if they had been written as subqueries.
>
> So this does not really add any new functionality, it's just variant
> syntax for something you can do about as easily without it, right?

Not totally as easily. For example, you can do some kinds of
aggregation with a few fewer keystrokes.

> The downside that I see is is that it changes WITH and SET into fully
> reserved words, which no doubt will break a few people's applications.

Really?

> While we're probably going to have to do that eventually, I'd like
> to be able to point to some non-negligible benefit resulting from
> the change when we do it.
>
> So my inclination is to not apply this in its current form, but to
> wait for the full recursive-WITH feature before taking the
> compatibility hit.

Is there some way to poll people for uses of WITH and SET in places
they shouldn't be?

Cheers,
D
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
phone: +1 415 235 3778 AIM: dfetter666
Skype: davidfetter

Remember to vote!
Consider donating to PostgreSQL: http://www.postgresql.org/about/donate

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-04-10 01:05:06 Re: RESET SESSION v3
Previous Message Tom Lane 2007-04-09 22:43:08 Re: non-recursive WITH clause support