Re: Arrays of Complex Types

From: David Fetter <david(at)fetter(dot)org>
To: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Arrays of Complex Types
Date: 2007-03-26 01:31:58
Message-ID: 20070326013158.GA16551@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

I wrote:

> I'd like to take the TODO item that reads, "Add support for arrays of
> complex types," but before I start patching, I'd like to see whether
> what I'm about to do makes any sense:

I've written up a patch intended to implement this on the
non-pg_catalog tables and VIEWs, but while it builds, it doesn't
initdb. Enclosed are the patch and the error log.

Any hints as to what I might look at?

Cheers,
David.

>
> 1. In src/backend/commands/tablecmds.c, change DefineRelation as
> follows:
>
> * After the first call to heap_create_with_catalog, construct and
> do another call to for the array type.
>
> * Add an appropriate pg_depend entry.
>
> 2. Change RemoveRelation to reflect the above.
>
> 3. Change TypeRename appropriately, whatever that turns out to be.
>
> Does the above make sense? Have I missed anything critical?
>
> Cheers,
> D
> --
> David Fetter <david(at)fetter(dot)org> http://fetter.org/
> phone: +1 415 235 3778 AIM: dfetter666
> Skype: davidfetter
>
> Remember to vote!
> Consider donating to PostgreSQL: http://www.postgresql.org/about/donate
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: Don't 'kill -9' the postmaster

--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
phone: +1 415 235 3778 AIM: dfetter666
Skype: davidfetter

Remember to vote!
Consider donating to PostgreSQL: http://www.postgresql.org/about/donate

Attachment Content-Type Size
array_of_complex.diff text/plain 4.2 KB
initdb.log text/plain 916 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message ITAGAKI Takahiro 2007-03-26 01:39:17 Server-side support of all encodings
Previous Message ITAGAKI Takahiro 2007-03-26 00:46:47 Re: Load distributed checkpoint V3

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-03-26 02:18:14 Re: Arrays of Complex Types
Previous Message ITAGAKI Takahiro 2007-03-26 00:46:47 Re: Load distributed checkpoint V3