| From: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | pgsql-patches(at)postgresql(dot)org |
| Subject: | vacuumdb cancel handler |
| Date: | 2007-03-19 02:06:33 |
| Message-ID: | 20070319104134.6B52.ITAGAKI.TAKAHIRO@oss.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Hello,
I found vacuumdb, reindexdb and clusterdb don't have cancel handlers.
The server continues to process commands when we press Ctrl+C on those
client programs, though they exit. Therefore, "psql -c VACUUM" and Ctrl+C
works well, but vacuumdb and Ctrl+C does not.
I borrowed the cancel handler from psql and add it into vacuumdb, reindexdb
and clusterdb. Other programs in src/bin/scripts also have the same problem,
but I think it is worth porting only for maintenance commands because they
take long time.
This bug (or spec?) exists in 7.4, 8.0, 8.1 and 8.2. Those commands
were wrappers of psql at 7.3 and we rewrote them into C programs at 7.4.
We might forget to port the feature then.
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| vacuumdb_cancel.patch | application/octet-stream | 10.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2007-03-19 08:48:19 | Re: ecpg threading vs win32 |
| Previous Message | ITAGAKI Takahiro | 2007-03-19 00:33:54 | Re: ecpg threading vs win32 |