Re: tsearch in core patch, for inclusion

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: tsearch in core patch, for inclusion
Date: 2007-02-21 14:01:51
Message-ID: 200702211401.l1LE1px27523@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Oleg Bartunov wrote:
> >> It's not so big addition to the gram.y, see a list of commands
> >> http://mira.sai.msu.su/~megera/pgsql/ftsdoc/sql-commands.html.
>
> > I looked at the diff file and the major change in gram.y is the creation
> > of a new object type FULLTEXT,
>
> You mean four different object types. I'm not totally clear on bison's
> scaling behavior relative to the number of productions, but I think
> there's no question that this patch will impose a measurable distributed
> penalty on every single query issued to Postgres by any application,
> whether it's heard of tsearch or not. The percentage overhead would
> be a lot lower if the patch were introducing a similar number of entries
> into pg_proc.

My point is that the grammar splits off all the tsearch2 objects by
prefixing them with CREATE FULLTEXT object, where there are four object
types supported.

But as others have pointed out, the performance of the grammar is
probably not an issue in this case.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2007-02-21 14:14:01 Re: New feature request: FlashBack Query
Previous Message Florian G. Pflug 2007-02-21 14:01:23 Re: New feature request: FlashBack Query

Browse pgsql-patches by date

  From Date Subject
Next Message Zdenek Kotala 2007-02-21 14:28:06 Re: BUG #2969: Inaccuracies in Solaris FAQ
Previous Message Alvaro Herrera 2007-02-21 13:59:30 Re: --enable-xml instead of --with-libxml?