From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | "Jignesh K(dot) Shah" <J(dot)K(dot)Shah(at)Sun(dot)COM> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Robert Lor <Robert(dot)Lor(at)Sun(dot)COM> |
Subject: | Re: fixing Makefile.shlib for solaris/gcc with -m64 flag |
Date: | 2007-02-20 22:46:01 |
Message-ID: | 200702202246.l1KMk1R19192@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
OK, I have made Solaris gcc the same as Linux in Makefile.shlib, patch
attached.
I am not backpatching this. We will get this tested for 8.3.
---------------------------------------------------------------------------
Jignesh K. Shah wrote:
> I dont think we solved this.. But I think the way to put -m64 should be same as in Linux and Solaris
> and not different.
>
> Thanks.
> Regards,
> Jignesh
>
>
> Tom Lane wrote:
> > Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> >> Am Mittwoch, 17. Januar 2007 17:12 schrieb Tom Lane:
> >>> "Jignesh K. Shah" <J(dot)K(dot)Shah(at)Sun(dot)COM> writes:
> >>>> simple if I use -m64 for 64 bit then all end binaries are generated
> >>>> 64-bit and the shared libraries are generated 32-bit and the compilation
> >>>> fails (ONLY ON SOLARIS) since that particular line is only for the
> >>>> condition Solaris AND gcc.
> >>>>
> >>>> If I use the COMPILER which is CC + CFLAGS it passes -m64 properly to it
> >>>> and generates shared libraries 64-bit and the compile continues..
> >>> Hmm ... I see we're doing it that way already for some other platforms,
> >>> but I can't help thinking it's a kluge. Wouldn't the correct answer be
> >>> that -m64 needs to be in LDFLAGS?
> >
> >> The correct answer may be to put -m64 into CC.
> >
> > Did we conclude that that was a satisfactory solution, or is this still
> > a live patch proposal?
> >
> > If -m64 in CC is the right solution, it should probably be mentioned in
> > FAQ_Solaris.
> >
> > regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Attachment | Content-Type | Size |
---|---|---|
/rtmp/diff | text/x-diff | 728 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2007-02-20 22:47:03 | Re: [pgsql-patches] O_DIRECT support for Windows |
Previous Message | Bruce Momjian | 2007-02-20 22:45:57 | pgsql: Change $(CC) to $(COMPILER) on Solaris gcc so -m64 is passed into |