Re: [HACKERS] SGML index build fix

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Martijn van Oosterhout <kleptog(at)svana(dot)org>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] SGML index build fix
Date: 2007-01-10 01:58:10
Message-ID: 200701100158.l0A1wAF08050@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > > ! draft:
> > > ! ifndef DRAFT
> > > ! ifneq ($(MAKECMDGOALS), draft)
>
> How could this condition ever match?

On first call, 'draft' might be set, but in the recursive call, this
code will not be reached because DRAFT iss set.

---------------------------------------------------------------------------

>
> > > ! # Call ourselves with the DRAFT value set. ?This seems to be the only
> > > ! # way to set gmake variables in a rule.
> > > ! ????(at)$(MAKE) DRAFT="Y" $(MAKECMDGOALS))
> > > ? else
> > > ! # run default 'all' rule
> > > ! ????(at)$(MAKE) DRAFT="Y" html
> > > ! endif
> > > ? endif
>
> --
> Peter Eisentraut
> http://developer.postgresql.org/~petere/
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message L Bayuk 2007-01-10 02:32:33 Building libpq/psql with Borland BCC5
Previous Message Bruce Momjian 2007-01-10 01:57:08 Re: [HACKERS] SGML index build fix

Browse pgsql-patches by date

  From Date Subject
Next Message L Bayuk 2007-01-10 02:32:33 Building libpq/psql with Borland BCC5
Previous Message Bruce Momjian 2007-01-10 01:57:08 Re: [HACKERS] SGML index build fix