From: | "Jim C(dot) Nasby" <jim(at)nasby(dot)net> |
---|---|
To: | Greg Sabino Mullane <greg(at)turnstep(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: bug in on_error_rollback !? |
Date: | 2006-10-30 16:40:43 |
Message-ID: | 20061030164043.GK11985@nasby.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Oct 27, 2006 at 01:19:25PM -0000, Greg Sabino Mullane wrote:
> > This is documented clearly on the psql man page, so it is simply not a
> > bug, and changing this would probably break lots of legacy scripts.
>
> In a general sense, perhaps, but in this *particular* case, I don't
> see what harm allowing "\set on_error_rollback" would be: it certainly
> won't break any existing scripts. I wrote this feature (but someone else
> chose the name!) and I still occasionally write it lowercase and wonder
> why it isn't working. :)
>
> Perhaps even allowing all of the \set commands to be case-insensitive
> may be a good idea?
The problem is that people my be depending on the case-sensitivity in
their scripts...
\set ACounter 1
\set aCounter 2
Of course, they're just asking for trouble, but suddenly making psql
variables case-insensitive would break that code.
Perhaps a good compromise would be adopting SQL case syntax (ie: you
have to wrap in double quotes to preserve case).
--
Jim Nasby jim(at)nasby(dot)net
EnterpriseDB http://enterprisedb.com 512.569.9461 (cell)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-10-30 17:05:19 | Re: WAL logging freezing |
Previous Message | Joshua D. Drake | 2006-10-30 16:27:37 | Index greater than 8k |