Re: New version of money type

From: "D'Arcy J(dot)M(dot) Cain" <darcy(at)druid(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: jim(at)nasby(dot)net, kleptog(at)svana(dot)org, llonergan(at)greenplum(dot)com, sfrost(at)snowman(dot)net, pgsql-hackers(at)postgresql(dot)org
Subject: Re: New version of money type
Date: 2006-10-12 16:36:46
Message-ID: 20061012123646.fb46105e.darcy@druid.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 28 Sep 2006 23:23:30 -0400
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > The existing type is depricated and has been since at least 8.1; so yes,
> > it's slated for removal.
>
> Well, my perception of that has always been "it needs to be upgraded or
> removed". So if D'Arcy wants to work on the improvement angle, I have
> no problem with him doing so. The thing we need to negotiate is "how
> much improvement is needed to keep it in core".

Well, the patch I submitted is definitely an improvement over the
existing version. Are you saying that I have to make further
improvements before these ones can be imported? ISTM that going to 64
bit without any other change is big enough to warrant the change as
is. Once that is done I would be happy to work on other improvements
but my experience tells me not to make more than one major change at a
time.

The one issue I have with my existing patch though is the removal of
the currency symbol from the output. There have been many suggestions
that that just gets in the way but, following up on my own statement
above, this is two changes, not one, and perhaps should be left out of
the patch for that reason.

--
D'Arcy J.M. Cain <darcy(at)druid(dot)net> | Democracy is three wolves
http://www.druid.net/darcy/ | and a sheep voting on
+1 416 425 1212 (DoD#0082) (eNTP) | what's for dinner.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-10-12 16:37:46 Re: [PERFORM] Hints proposal
Previous Message Csaba Nagy 2006-10-12 16:34:25 Re: Hints proposal