Re: pgstattuple extension for indexes

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: pgsql-patches(at)postgresql(dot)org
Cc: Satoshi Nagayasu <nagayasus(at)nttdata(dot)co(dot)jp>, ishii(at)sraoss(dot)co(dot)jp
Subject: Re: pgstattuple extension for indexes
Date: 2006-09-04 01:39:18
Message-ID: 20060904100418.5CCA.ITAGAKI.TAKAHIRO@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Patch applied. Thanks.

The two attached patches fix contrib/pgstattuple.

pgstattuple.c.diff removes the fragmemtation reporting in pgstattuple().
It is no longer needed, because pgstatindex() has upward functionality now.
Also, the report using elog was judged as improper in earlier discusses.

pgstattuple.sql.in.diff removes DROP statements in the installer. The DROP
statements make some unpleasant ERROR logs during install. According to
other contrib modules, DROPs should be in the uninstaller and should not
be in the installer.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center

Attachment Content-Type Size
pgstattuple.sql.in.diff application/octet-stream 1.3 KB
pgstattuple.c.diff application/octet-stream 7.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2006-09-04 01:42:45 Re: [HACKERS] Interval month, week -> day
Previous Message Tom Lane 2006-09-04 01:33:58 Re: [HACKERS] Interval month, week -> day

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2006-09-04 01:42:45 Re: [HACKERS] Interval month, week -> day
Previous Message Tom Lane 2006-09-04 01:33:58 Re: [HACKERS] Interval month, week -> day