Re: Some minor changes to pgbench

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Some minor changes to pgbench
Date: 2006-08-24 04:01:21
Message-ID: 20060824123224.588D.ITAGAKI.TAKAHIRO@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Joshua D. Drake" <jd(at)commandprompt(dot)com> wrote:

> >> Would it be worthwhile to add a switch so that the foreign key test is
> >> only used "if" they use the switch in conjunction with a -i?
> >
> > I wouldn't object to providing that as a (non default) option.
>
> O.k. I will take a look at what that would take..

If we provide 'external initializer', some of your proposals can be done
through more generalized way, at least the foreign key test. It is a
replacement of the DDLAFTERs[], which is a hard-codeded list in the source
code to create primary keys. It may help other people, for example, who want
to test the performance of hash index instead of btree index (primary key).

Using it, you can use the below script or something:

$ pgbench -i -f init_with_fkey.sql
[init_with_fkey.sql]
alter table branches add primary key (bid);
...
alter table tellers add constraint tellers_bid_fkey
foreign key (bid) references branches (bid);
...

Are you interested in this idea?

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-08-24 04:09:43 Re: Some minor changes to pgbench
Previous Message Alvaro Herrera 2006-08-24 03:50:47 Re: pgsql-patches reply-to (was Re: [PATCHES] selecting large result sets in psql using cursors)

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-08-24 04:09:43 Re: Some minor changes to pgbench
Previous Message Alvaro Herrera 2006-08-24 03:50:47 Re: pgsql-patches reply-to (was Re: [PATCHES] selecting large result sets in psql using cursors)