Re: [Patch] - Fix for bug #2558, InitDB failed to run on windows 2003

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: dror <dror_b(at)hotmail(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [Patch] - Fix for bug #2558, InitDB failed to run on windows 2003
Date: 2006-08-14 16:40:25
Message-ID: 20060814164025.GA3110@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

dror wrote:

> There were two options to solve this issue:
>
> Create a new file , grant a write permission for the Postgres user
> and redirect the output to that file. (EnterpriseDB use this method)
> Canceling the redirection at all.
>
> I choose the second option and omit the redirection in any case that
> it windows machine and the redirection was sent to DEVNULL.
>
> The only files that I changed are: initDB.c, exec.c and pg_ctl.c

Please submit the changes as patches, instead of the whole files. Also,
please specify which branch do these patches apply -- is this for 8.1,
or for the current development code? When checked against the 8.1
pg_ctl.c, the file you sent only contains a regression for a bug fix,
and no change related to what you describe above.

On the other hand, it may be useful to lose the redirection only on the
cases where it fails, so we still have reasonable behavior on non-broken
platforms. Or maybe there's a better solution.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2006-08-14 17:03:52 Re: [Patch] - Fix for bug #2558, InitDB failed to run
Previous Message Michael Meskes 2006-08-14 16:31:52 Re: ecpg tests make failed on Win32/MinGW

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2006-08-14 17:03:52 Re: [Patch] - Fix for bug #2558, InitDB failed to run
Previous Message Joshua D. Drake 2006-08-14 16:10:37 Re: [PATCHES] Adding fulldisjunctions to the contrib