| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-patches(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org, Zdenek Kotala <Zdenek(dot)Kotala(at)sun(dot)com> |
| Cc: | Joachim Wieland <joe(at)mcknight(dot)de>, bruce(at)momjian(dot)us |
| Subject: | Re: Allow commenting of variables in postgresql.conf to - |
| Date: | 2006-07-31 18:49:40 |
| Message-ID: | 200607312049.41855.peter_e@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Zdenek Kotala wrote:
> I performed some cleanup in my code as well. I reduced some
> conditions, which cannot occur and fixed context validation in the
> set_config_options function. I hope that It is final version of our
> patch.
The way I see it, combining a feature change with a code refactoring and
random white space changes is a pretty optimal way to get your patch
rejected. Please submit patches for these items separately.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2006-07-31 18:57:35 | Re: [HACKERS] 8.2 features? |
| Previous Message | Stefan Kaltenbrunner | 2006-07-31 18:17:46 | Re: Going for "all green" buildfarm results |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2006-07-31 18:57:35 | Re: [HACKERS] 8.2 features? |
| Previous Message | Jim C. Nasby | 2006-07-31 16:40:21 | Re: [HACKERS] extension for sql update |