Re: Re-thing PG_MODULE_MAGIC

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: josh(at)agliodbs(dot)com, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Re-thing PG_MODULE_MAGIC
Date: 2006-06-16 04:01:53
Message-ID: 200606160401.k5G41rW18236@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Josh Berkus wrote:
> >>> The <quote>magic block</> present in all PostgreSQL-supported libraries
> >>> is checked to guarantee compatibility. For this reason, non-PostgreSQL
> >>> libraries cannot be loaded in this way.
> >>
> >> you need "must be" before "present".
>
> > Uh, the point is not that they need a magic block (though they do), but
> > rather that the magic block is always checked.
>
> It's a grammar complaint, not a factual complaint. Personally I'd
> suggest wording it as "the magic block required in all ..."

OK, new text:

The <quote>magic block</> required in all PostgreSQL-supported libraries
is checked to guarantee compatibility. For this reason, non-PostgreSQL
libraries cannot be loaded in this way.

--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message mark 2006-06-16 04:04:15 Re: Preventing DELETE and UPDATE without a WHERE clause?
Previous Message Bruce Momjian 2006-06-16 03:57:22 Re: Test request for Stats collector performance improvement